Data Driven QML updates for LogPanel and TrackingSignals tabs #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drives the update of the LogPanel from the incoming data rather than a 5hz timer. This also migrates to registering the python logging classes with QML via the new @QmlElement attribute introduced in PySide6.
emptySeries was never used in TrackingSignalsTab, removing it.
This drives the update of the TrackingSignalsTab from the incoming data rather than a 5hz timer. This also migrates to registering the python classes with QML via the new @QmlElement attribute introduced in PySide6.
This drives the update of the TrackingSkyPlotTab from the incoming data rather than a 5hz timer. This also migrates to registering the python classes with QML via the new @QmlElement attribute introduced in PySide6. NOTE: This is incomplete, because the labels flicker due to deletion after a set timeout. This logic needs to change, now that we do not update at a predictable interval.
…f timer" This reverts commit 949bd2a. This is not yet ready, as it creates flickering due to the way that the SkyPlot point labels are deleted and re-created. They depended on the timer-based update interval, and now that it is at an unpredictable update interval, another means of achieving the label updates needs to occur.
keithel-qt
changed the title
silverjam
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive LogPanel and TrackingSignalsTab updates from incoming data instead of timer.
This drives the update of the tabs from the incoming data rather than a 5hz timer.
This also migrates to registering the python classes with QML via the new @QmlElement attribute introduced in PySide6.
Note: TrackingSkyPlot data driven updates is not yet complete because of the way the labels get destroyed and re-created.
They were depending on the update frequency of the timer. This still needs resolving, and thus TrackingSkyPolot data driven updates has been reverted.