Skip to content

Conversation

adrian-kong
Copy link
Contributor

@adrian-kong adrian-kong commented Oct 25, 2022

unsure if this was what it as asking

@adrian-kong adrian-kong requested a review from silverjam October 25, 2022 02:15
@adrian-kong adrian-kong changed the title modify unwraps [DEVINFRA-320] modify unwraps [CPP-320] Oct 25, 2022
@silverjam
Copy link
Contributor

@john-michaelburke Is this all there was for this ticket?

@john-michaelburke
Copy link
Collaborator

@john-michaelburke Is this all there was for this ticket?

I think there are a lot more when I search for unwrap in the repo. At the time, I think my intention was that we would just use at least expect in place of unwrap. We use unwrap in a lot of our unittests so finding them will be a bit tedious. Fortunately, any that are in tests are most certainly at the bottom of the file so it should be easier to find.

There is also the case where some of the unwraps are acceptable to unwrap but use your best judgement:
https://blog.burntsushi.net/unwrap/

@adrian-kong adrian-kong merged commit 680c80c into main Oct 25, 2022
@adrian-kong adrian-kong deleted the adrian/unwraps branch October 25, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants