[CPP-242][CPP-243]LogLevel, uprev py2many, fix broken csv/sbp logging. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
john-michaelburke/loglevel
branch
from
7ca7ef1 to
7b37f66
Compare
john-michaelburke
force-pushed
the
john-michaelburke/loglevel
branch
from
7b37f66 to
f494a11
Compare
| } | ||
| } | ||
|
|
||
| impl FromStr for CliLogLevel { |
There was a problem hiding this comment.
Needed a second type so I could overload the from_str (already set in py2many via EnumString) function to display available variants to the user if they mispell one.
| .unwrap(); | ||
|
|
||
| log::set_boxed_logger(Box::new(logger)).expect("Failed to set logger"); | ||
| log::set_max_level(log::LevelFilter::Info); |
There was a problem hiding this comment.
Moved this to handle_cli function to set based off cli if provided.
jayvdb
suggested changes
Jun 26, 2021
| class LogLevel(str, Enum): | ||
| ERROR = "ERROR" | ||
| WARNING = "WARNING" | ||
| NOTICE = "NOTICE" |
There was a problem hiding this comment.
NOTICE is a Python logging level, and a valid logging level in sbp / the piksi. Rust needs to not use it, as it isnt valid there.
There was a problem hiding this comment.
Fair enough. I'll link it to warnings.
jayvdb
approved these changes
Jun 26, 2021
silverjam
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.