remove titles of magnetometer, spectrum analyzer, raw imu [CPP-434] #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit. With any visual changes to the app, I will say it is nice if you can take some photos to show a side-by-side and dump them in the PR so the reviewer doesn't have to validate them locally. |
|
Titles removed in these tabs: Before vs After:
|
joelynch
approved these changes
Oct 26, 2022
|
Strange it seems to be failing on this line: |
silverjam
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple PR to remove these titles displayed in the tab, think it might be ok to remove these as you would think the plot is spectrum analyzer if you are in the spectrum anaylzer tab?