qml optimizations [CPP-818] #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
front end benchmarks seem to run a bit slower compared to main branch |
|
@keithel-qt can you review please? |
| for (var idx in Constants.advancedImu.lineColors) { | ||
| if (lineLegendRepeaterRows.itemAt(idx)) | ||
| lineLegendRepeaterRows.itemAt(idx).children[0].color = Constants.advancedImu.lineColors[idx]; | ||
| let imuLineColors = Constants.advancedImu.lineColors; |
There was a problem hiding this comment.
Not that I have any way to validate my hunch but I imagine this originally would have only counted as a single "resolve" event.
Two thoughts:
|
|
manually benchmarking, this seems to do inconsistent ±1-2% cpu utilization, seems too little to actually know if this is improving |
|
Create a test tag to trial this on a low power machine: https://github.com/swift-nav/swift-toolbox/releases/tag/v4.1.4-qmlopt (still building) |
|
|
|
|
silverjam
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came across these pages for optimizations:
https://doc.qt.io/qt-6/qtquick-performance.html#resolving-properties
and
https://doc.qt.io/qt-6/qtquick-performance.html#property-bindings