-
Notifications
You must be signed in to change notification settings - Fork 2
enable opengl functionality [CPP-805] #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We may want to gate this on only non-windows machines because I think we hardcode this environment to get rid of some weird artifacts that were appearing in windows. That being said, this was probably the case for PySide2 i.e. Qt5. I'm not sure if this is easily reproducible though maybe @silverjam could test this out on his lower-end machine. Another idea would be to just comment out the logic and uncomment if the issue re-arises 🤷 swift-toolbox/entrypoint/src/main.rs Line 88 in 607625d
Also interesting these are different env variables. |
I found an extremely verbose unofficial? description of the various configurations:
I'm sure @keithel-qt may have some insight. |
What is the goal here? |
it seems like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrian-kong this is good to ship
after long and hard testing...
it seems...
RHI backend defaults to directx and metal for win, mac respectively, we need to assign it as opengl manually or it wont work.
this simply enables opengl functionality, tested working for mac,
does not resolve these issues in the log...