Removal of 'SwiftNav' Qt Quick Control style #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
"Binding on indicator is not deferred as requested by the
DeferredPropertyNames class info because it constitutes a group
property."
This fixes one instance of the Binding not deferred warning.
It also shows better form - where you should not infer the
implementation of a QML Item from another QML file that uses it. Alter
internals using toplevel properties instead.
Because QTBUG-108518 will not be resolved in time for 6.5, we must remove the use of custom Qt Quick Control Styles that require fallback to another style, as the fallback style's theme does not properly initialize. (See bug). This removes SwiftNav style controls for all but TabBar and TabButton. Some additional things done here: * Remove use of SwiftButton where the customization done in SwiftButton was not used, and Material button is more appropriate to use with the same look and feel. * Remove use of SwiftComboBox where the customization done in SwiftComboBox was not used, and Material ComboBox is more appropriate to use with the same look and feel.
Because QTBUG-108518 will not be resolved in time for 6.5, we must
remove the use of custom Qt Quick Control Styles that require fallback
to another style, as the fallback style's theme does not properly
initialize. (See bug).
This removes the SwiftNav style Qt Quick Controls.
Some additional things done here:
* Remove use of SwiftButton where the customization done in
SwiftButton was not used, and Material button is more appropriate
to use with the same look and feel.
* Remove use of SwiftComboBox where the customization done in
SwiftComboBox was not used, and Material ComboBox is more
appropriate to use with the same look and feel.
* Remove access to change orientation of TabBar, as this was never
used. It was originally added, as the original implementation of
the SideNavBar was originally implemented with an altered Vertical
TabBar, however when I refactored it, I found that TabBar was not
the right tool for the job, and abandoned the TabBar based
SideNavBar implementation. This was a vestige of that logic.
* Use swiftWhite constant instead of literal "white".
* Tweaks to the SwiftTabButtons on the TabInfoBar to make it
display correctly.
|
Frontend and Release Workflow Started here |
silverjam
approved these changes
Dec 7, 2022
john-michaelburke
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of 'SwiftNav' Qt Quick Control style
Because QTBUG-108518 will not be resolved in time for 6.5, we must remove the use of custom Qt Quick Control Styles that require fallback to another style, as the fallback style's theme does not properly initialize. (See bug).
This removes the SwiftNav style Qt Quick Controls.
Some additional things done here: