Instructions and targets for debugging Qt and PySide6 #879
Conversation
keithel-qt
commented
Dec 21, 2022
keithel-qt
commented
- Add cargo make targets that build and install PySide6 from source
- prep-debug-pyside
- build-pyside
- build-dist-install-pyside
- build-install-pyside
- Add new README.debug.md describing how to use the debug targets.
- Add some scripts that aid debugging intermittent crashes.
- Remove PySide6 as dependency from pyproject.toml (that flit reads). This is because we now manually install it, as we may install from built wheel, or from pip.
* Add cargo make targets that build and install PySide6 from source - prep-debug-pyside - build-pyside - build-dist-install-pyside - build-install-pyside * Add new README.debug.md describing how to use the debug targets. * Add some scripts that aid debugging intermittent crashes. * Remove PySide6 as dependency from pyproject.toml (that flit reads). This is because we now manually install it, as we may install from built wheel, or from pip.
Makefile.toml
Outdated
| cm_run_task get-qt-version | ||
| cm_run_task build-install-pyside | ||
| else | ||
| exec --fail-on-error ${PYTHON} -m pip install PySide6==6.3.2 |
There was a problem hiding this comment.
Hardcoding the version here will diverge from our pyproject.toml Nevermind I see you removed it there. We should probably expose this as a global variable within the Makefile.toml though so we don't have to modify it in this task and prep-dist later on.
There was a problem hiding this comment.
Maybe there is a way to conditionalize the installation of this in flit? so it doesn't get installed if we're doing a debug build, but does otherwise? Not sure how that could be conditionalized.
There was a problem hiding this comment.
Yeah, we could work something out. Maybe the @swift-nav/devinfra team can help take it over. We would certainly want it to be in lockstep with CI first and foremost.
There was a problem hiding this comment.
I think a global variable is a good first step, so we don't have to update the version in multiple places.
| From bd7b811ed1a5c53b493016847165844ce595f53e Mon Sep 17 00:00:00 2001 | ||
| From: Keith Kyzivat <[email protected]> | ||
| Date: Wed, 21 Dec 2022 09:07:34 -0500 | ||
| Subject: [PATCH] Properly fall back if INCLUDEPY config_var !exist |
There was a problem hiding this comment.
will this patch be upstreamed to pyside-setup?
|
Frontend and Release Workflow Started here |
|
@adrian-kong please merge at your leisure |
5 participants
