pass and update current index [CPP-852] #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-kong
commented
Jan 3, 2023
|
|
||
| @classmethod | ||
| def post_data_update(cls, update_data: Dict[str, Any]) -> None: | ||
| update_data[Keys.SBP_LOGGING_FORMAT_INDEX] = update_data[Keys.SBP_LOGGING_LABELS].index(update_data[Keys.SBP_LOGGING_FORMAT]) |
There was a problem hiding this comment.
it might be better to have this posted in capnproto but we construct the string model here so will just leave it here...
resources/LoggingBar.qml
Outdated
| if (loggingBarData.recording_filename) | ||
| recordingFilenameText.editText = loggingBarData.recording_filename; | ||
| let recording = sbpLoggingButton.checked || csvLoggingButton.checked; | ||
| let recording = loggingBarData.sbp_logging || loggingBarData.csv_logging; |
There was a problem hiding this comment.
I might be out of the loop on this but I'm not sure we want to mix these up. What happens if you record sbp and csv at the same time? The csv logging button indicates it is recording by being in the "clicked" state.
john-michaelburke
approved these changes
Jan 4, 2023
adrian-kong
added a commit
that referenced
this pull request
Jan 9, 2023
* refactoring sbp logger * refactoring sbp logger * serialize return bytes * clippy + output correct data bytes * More idiomatic * fmt clippy * remove stop recording * fmt * fix spamming close_sbp * fmt * pass and update current index [CPP-852] (#888) * pass format index as field * handle only init * only init once for interactive components * pylint * should only reflect counters when sbp is logging * fmt * changed to SbpFileLogger * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is only required to handle the initial case (can be modified by CLI).
currentIndex and checked is interactive and can only be changed via onActivated elsewhere hence we can just allow the interactive component to handle modifications of these variables.