Skip to content

Implements zoom feature for SolutionPosition[CPP-96]. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Implements zoom feature for SolutionPosition[CPP-96]. #89

merged 1 commit into from
Jul 14, 2021

Conversation

@john-michaelburke
Copy link
Collaborator

Implements

  • Zoom feature for Solution Position Plot.
  • Moved related javascript work out of BaselineComponents to a common folder which now Solution Position and Baseline import.
  • Added needed features to make the common javascript file agnostic to both plots.
  • Removed code now deprecated by this approach.

@john-michaelburke john-michaelburke changed the title Implements zoom feature for SolutionPosition. Implements zoom feature for SolutionPosition[CPP-96]. Jul 14, 2021
john-michaelburke
john-michaelburke commented Jul 14, 2021
View reviewed changes
resources/SolutionPlotCommon/SolutionPlotLoop.js
// Baseline Plot Loop functions.
.pragma library

.import QtCharts 2.15 as QtCharts
Copy link
Collaborator Author

@john-michaelburke john-michaelburke Jul 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A majority of this file was originally resources/BaselineTabComponents/BaselinePlotLoop.js, I'm not sure why github did not catch the 'rename'.

Added the use_ref / use_lines functionality and generalized the createScatter function to now createSeries to be able to create scatter or lines.

@john-michaelburke john-michaelburke requested a review from jayvdb July 14, 2021 01:09
@john-michaelburke john-michaelburke marked this pull request as ready for review July 14, 2021 01:09
@john-michaelburke john-michaelburke requested a review from a team July 14, 2021 01:09
@john-michaelburke john-michaelburke merged commit 0b11252 into main Jul 14, 2021
@john-michaelburke john-michaelburke deleted the john-michaelburke/solution_position_zoom branch July 14, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jayvdb jayvdb jayvdb approved these changes

@silverjam silverjam silverjam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@john-michaelburke @jayvdb @silverjam