Patrick/code cleanup #890
Merged
Patrick/code cleanup #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s inline, better testing error msgs
pcrumley
commented
Jan 6, 2023
|
Frontend and Release Workflow Started here |
|
Frontend and Release Workflow Started here |
adrian-kong
approved these changes
Jan 12, 2023
| /// Initiates preprocessing of solution data and handles frontend input. | ||
| /// | ||
| /// TODO(johnmichael.burke@) https://swift-nav.atlassian.net/browse/CPP-245 | ||
| /// TODO(johnmichael.burke@) <https://swift-nav.atlassian.net/browse/CPP-245> |
There was a problem hiding this comment.
think we can remove this and the missing functionalities comment
pcrumley
commented
Jan 12, 2023
|
Frontend and Release Workflow Started here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly opinionated cosmetic refactor of swift-toolbox, and some minor other fixes. Here they are.
name/mod.rs. To me, this style is cleaner, I am happy to revert this change.cargo doc --document-private-itemsand just look over the docs that were created. It was useful to help me get acclimated to this crate anyway. Closes https://swift-nav.atlassian.net/browse/CPP-348utils/mod.rsunit tests to use a case based test framework, have the message thrown if test fails be more helpful when comparing floats & byte strings.Sorry to put these all together, I should have done them as separate PRs.