[CPP-30]Backend CPU Usage benchmark. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-michaelburke
force-pushed
the
johnmichael-burke/backend_benchmark
branch
10 times, most recently
from
07c484a to
1b1668c
Compare
silverjam
reviewed
Feb 24, 2021
john-michaelburke
force-pushed
the
johnmichael-burke/backend_benchmark
branch
from
1b1668c to
55f50d4
Compare
john-michaelburke
force-pushed
the
johnmichael-burke/backend_benchmark
branch
from
55f50d4 to
a1f1e3f
Compare
|
@silverjam Took the cake on this PR. Everything looks good to me though! |
silverjam
reviewed
Feb 25, 2021
silverjam
reviewed
Feb 25, 2021
silverjam
reviewed
Feb 25, 2021
silverjam
reviewed
Feb 25, 2021
silverjam
reviewed
Feb 25, 2021
console_backend/benches/benches.rs
Outdated
| group.measurement_time(time::Duration::from_millis(BENCHMARK_TIME_LIMIT)); | ||
| group.sample_size(BENCHMARK_SAMPLE_SIZE); | ||
| group.bench_function("RPM_failure", |b| { | ||
| b.iter(|| run_process_messages_failure(file_in_name)) |
There was a problem hiding this comment.
Same here, I think we can easily refactor this to just use a "if (failure) { blah }"?
There was a problem hiding this comment.
Done. It seems you can just add another "bench_function" and they can be contained within the same group.
silverjam
approved these changes
Feb 26, 2021
john-michaelburke
force-pushed
the
johnmichael-burke/backend_benchmark
branch
from
56286ae to
6f4356f
Compare
notoriaga
reviewed
Feb 26, 2021
| messages: impl Iterator<Item = sbp::Result<SBP>>, | ||
| client_send_clone: mpsc::Sender<Vec<u8>>, | ||
| ) { | ||
| let mut hpoints: Vec<(f64, OrderedFloat<f64>)> = vec![]; |
There was a problem hiding this comment.
A type alias type Point = (f64, OrderedFloat<f64>) might be nice here
| let mut hpoints: Vec<(f64, OrderedFloat<f64>)> = vec![]; | ||
| let mut vpoints: Vec<(f64, OrderedFloat<f64>)> = vec![]; | ||
| let mut sat_headers: Vec<u8> = vec![]; | ||
| let mut sats: Vec<Vec<(f64, OrderedFloat<f64>)>> = vec![]; |
There was a problem hiding this comment.
sats could probably be HashMap<u8, Vec<Point>>
notoriaga
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: It seems this benchmark does not ever complete in Windows locally or in github actions. I suspect there is a difference in how Windows and Linux are handling the spawned thread in the benchmark. May need some other rustaceans to point out what I could be doing wrong.
I created a ticket here to address the Windows issue. https://swift-nav.atlassian.net/browse/CPP-67
Also since the benchmarks seem to be longer running I figure theyd be best parallelized with the Build Checks stage then Installers requires both stages to complete.