Skip to content

Conversation

adrian-kong
Copy link
Contributor

for the file attached in ticket gives elevation angle of -91 which causes

thread '<unnamed>' panicked at 'attempt to subtract with overflow', console_backend/src/tabs/tracking_tab/tracking_sky_plot_tab.rs:87:25

since sbp docs say elevation is supposed to be (-90, 90), will just skip on these invalid values.

@adrian-kong adrian-kong requested a review from a team February 22, 2023 00:59
@swiftnav-travis
Copy link

Frontend and Release Workflow Started here

@adrian-kong
Copy link
Contributor Author

ignore failing CI atm - codesigning QtWebEngine for maps does not exist in non map

Copy link
Contributor

@joelynch joelynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks dodgy

@adrian-kong adrian-kong merged commit 2fb4d6e into main Feb 27, 2023
@adrian-kong adrian-kong deleted the adrian/skyplot_fix branch February 27, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants