mapping accuracy ellipse [CPP-906] #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Mobarak <[email protected]>
adrian-kong
commented
Mar 6, 2023
adrian-kong
commented
Mar 6, 2023
|
Frontend and Release Workflow Started here |
ljbade
reviewed
Mar 7, 2023
ljbade
requested changes
Mar 7, 2023
|
Frontend and Release Workflow Started here |
ljbade
approved these changes
Mar 8, 2023
ljbade
reviewed
Mar 8, 2023
| * @param points optional number of points to render ellipse, higher for smoothness | ||
| * @return {{geometry: {coordinates: [][], type: string}, type: string}} | ||
| */ | ||
| function createGeoJsonEllipse(center, rX, rY, points = 32) { |
There was a problem hiding this comment.
the ellipse code will be useful if in future we want to plot the MSG_POS_LLH_ACC: or MSG_POS_LLH_COV: messages which allow break down of the horizontal accuracy into North/South and East/West components
|
Frontend and Release Workflow Started here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.