generate js file with token task [CPP-912] #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Mobarak <[email protected]>
silverjam
reviewed
Mar 8, 2023
|
Frontend and Release Workflow Started here |
silverjam
reviewed
Mar 8, 2023
|
Frontend and Release Workflow Started here |
|
Frontend and Release Workflow Started here |
silverjam
reviewed
Mar 8, 2023
Co-authored-by: Jason Mobarak <[email protected]>
|
Frontend and Release Workflow Started here |
adrian-kong
commented
Mar 8, 2023
silverjam
reviewed
Mar 8, 2023
Co-authored-by: Jason Mobarak <[email protected]>
|
Frontend and Release Workflow Started here |
|
Frontend and Release Workflow Started here |
|
Frontend and Release Workflow Started here |
|
https://github.com/swift-nav/swift-toolbox-ci/actions/runs/4370355661 built artifacts generates mapbox token OK and tested running on mac |
silverjam
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hide access token, we will compile
trajectory_raw.jsintotrajectory.jsreplacing %ACCESS_TOKEN% with env varCreates
trajectory.jsvia taskcargo make map-js-tokenrequiring $MAPBOX_TOKEN.Modify
trajectory_raw.jsto adjust map,cargo make generate-resourceswill generate the mapped token via env var.Will need to create MAPBOX_TOKEN secret for private CI, is ok for public CI.