Move main tabs to side,add logos to tabs,dummy side drawer[CPP-273] #97
Conversation
| TrackingTab { | ||
| } | ||
|
|
||
| SolutionTab { | ||
| } | ||
|
|
||
| BaselineTab { | ||
| } | ||
|
|
||
| ObservationTab { |
There was a problem hiding this comment.
This portion is what became MainTabs.qml
| TabBar { | ||
| id: tab | ||
|
|
||
| Layout.fillWidth: true | ||
| z: Constants.commonChart.zAboveCharts | ||
| currentIndex: Globals.initialMainTabIndex | ||
| contentHeight: Constants.tabBarHeight | ||
|
|
||
| Repeater { | ||
| model: ["Tracking", "Solution", "Baseline", "Observations", "Settings", "Update", "Advanced"] |
There was a problem hiding this comment.
This portion is what became SideNavBar.qml
|
The initial Solution tab looks a bit odd now. Baseline is similar. Not caused by this PR, but it becomes more pronounced now. Perhaps the table outline could be rendered even when disconnected, as the table headers are constant. The License tab could be filled with license info for Roboto and fontawesome fonts/icons. wrt fontawesome license , it looks like were only using the Icons at https://fontawesome.com/license/free, in which case we only need to refer to https://creativecommons.org/licenses/by/4.0/ . https://github.com/swift-nav/console_pp/blob/858e13f4dcd41578530a3dad61e5a27f73c06caf/resources/images/fontawesome/LICENSE-OLD.txt can be deleted as that is only for code from fontawesome, and we're not reusing any of their code. |
|
See an odd issue with Windows, no tabs / buttons are showing up:
|
Looks like you can drag the sidebar as well to the left and see the icons. Something must not be consistent between operating systems I'll take a look. |
|
@jayvdb Done. I enabled the solution/baseline tables whenever the app starts. I added a popup for the licenses with tabs for the icons license and the roboto license. |
resources/Constants/utils.js
Outdated
| } | ||
|
|
||
| // Read text from file and store it into the "text" property of the "ele" object. | ||
| function readTextFile(path, ele){ |
There was a problem hiding this comment.
ele -> elem; but could be done in the next PR, if there are no other reasons to update this one.
Also would be great if the license links in the popup were clickable; IMO defer this for a rainy day.
There was a problem hiding this comment.
I converted the variable name but I agree to put off the hyperlinks for a rainy day. I was going down a pretty gnarly regex rabbit hole 😂 https://swift-nav.atlassian.net/browse/CPP-274
resources/Constants/utils.js
Outdated
|
|
||
| // Read text from file and store it into the "text" property of the "ele" object. | ||
| function readTextFile(path, elem){ | ||
| var req = new XMLHttpRequest; |
There was a problem hiding this comment.
Does this work correctly? I thought the syntax was like this:
| var req = new XMLHttpRequest; | |
| var req = new XMLHttpRequest(); |
Example: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest
There was a problem hiding this comment.
Looks like it works either way. I just added the parentheses anyway.
john-michaelburke
force-pushed
the
john-michaelburke/ui_fun
branch
from
f2a584d to
759c867
Compare
https://code.qt.io/cgit/qt/qtquickcontrols2.git/tree/examples/quickcontrols2/gallery/gallery.qml?h=5.15