-
Notifications
You must be signed in to change notification settings - Fork 2
improve map performance [CPP-916] #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Frontend and Release Workflow Started here |
Frontend and Release Workflow Started here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This a pretty difficult thing to review other than just a rubber stamp, but it looks fine?
marking as request changes because you need to update the documentation or undo a refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of disagree with decision to remove the comments, i think putting it as an inline comment makes more sense but i don't think it should block merge.
Frontend and Release Workflow Started here |
think it might be changed in later PRs if the optimal # of points for zoom levels is figured out |
https://docs.mapbox.com/help/troubleshooting/mapbox-gl-js-performance/