add loader [CPP-920] #987
Merged
add loader [CPP-920] #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screen.Recording.2023-04-04.at.9.13.06.am.movthink this looks way better. (will have to address the case when tcp connected but no settings etc... maybe just make this bar only on refresh action + write action?) |
|
Frontend and Release Workflow Started here |
silverjam
reviewed
Apr 4, 2023
| "Name": "", | ||
| "Value": "" | ||
| }] | ||
| rows: [] |
There was a problem hiding this comment.
Why do we need to remove this?
There was a problem hiding this comment.
this creates an empty row here:
There was a problem hiding this comment.
removing it makes it like this:
silverjam
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My.Movie.1.mp4
sped up by x4.
loader shows when clicking refresh button
ideally might change this to not use qml loaders, wanting to make this a single bar and do some lerping so it will look much cleaner (?)
trying to figure out how to best design this but sucks cant hotswap changes directly on console 🤮