disabled on default, swap to --enable-map #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-kong
commented
Mar 26, 2023
| SolutionMap.send_pos(m.solutionPositionStatus) | ||
|
|
||
| if MAP_ENABLED: | ||
| SolutionMap.send_pos(m.solutionPositionStatus) |
There was a problem hiding this comment.
i dont really like this hacky business but:
the cpu / mem issue lies in sending position in the background
- this was done because sending an array of points via signals was more complex (i.e. sending array of pts then sending one by one updates, caching a bunch of pts etc...)
- but an issue is webengineview linked to the webchannel, (if theres a way to somehow decouple these classes? - sending points in the background should be fine as long as its not sending to webchannel)
|
these changes seems to put qtwebengineprocess to 0% |
silverjam
approved these changes
Mar 27, 2023
|
Frontend and Release Workflow Started here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per memory / cpu usage request, disables map by default