Switch from swiftformat to swift-format #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Oct 16, 2023
|
I think it's okey to take the hit and do it all at once -- format the tests too; it'd be weird to only have a part of the codebase use a formatter |
|
@swift-server-bot add to allowlist |
|
Not sure why CI is failing, locally: On https://ci.swiftserver.group/job/swift-prometheus-soundness-prb/25/console : Does someone have access to more logs? |
FranzBusch
reviewed
Oct 16, 2023
FranzBusch
approved these changes
Oct 16, 2023
As of Swift 5.8, swift-format depends on the version of SwiftSyntax whose parser has been rewritten in Swift and no longer has dependencies on libraries in the Swift toolchain. Defaulting to Swift 5.8 fixes the usage of swift-format in nightly builds.
|
All checks now pass apart from Could someone with better access rights tell me what the CI step is running so that I can try to reproduce locally? Right now the output on Jenkins does not give me the details I need to pass this last check. |
|
The way to reproduce CI is:
hope this helps? |
FranzBusch
approved these changes
Oct 18, 2023
|
Thanks for the contribution @armandgrillet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made to close #94.
The code has been tested using
swift-format lint --configuration .swift-format --recursive Sources.Tests/PrometheusTestsshould be formatted as well but contains too many things to change for now, this is why I have started with onlySourcesand added"lineLength": 1000to limit the number of changes to do.