feat: add {emitToString, emitToBuffer} options + dedup TYPE and HELP per metric name #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incertum
commented
Aug 27, 2025
…per metric name
Add {emitToString, emitToBuffer} thread-safe internal buffer management variants to emit metrics.
Deduplicate TYPE and HELP lines per metric name by default on emit + enforce same HELP per metric name.
Signed-off-by: Melissa Kilby <[email protected]>
… sharing Revert to stricter mutual exclusivity constraints for metric name sharing with respect to labeled and unlabeled cases while still allowing different label sets per metric name. While Prometheus wouldn't break with sharing a metric name for labeled and unlabeled variants, the client enforces that each unique metric name must either be labeled (allowing multiple label sets) or unlabeled in order to support correct Prometheus aggregations. Use MetricFamily instead of MetricGroup. Signed-off-by: Melissa Kilby <[email protected]>
incertum
force-pushed
the
new/emit-to-string-alternative
branch
from
72e503b to
1184ea7
Compare
|
New emit variants should address thread-safety requirements #136. |
|
Fixes #137 |
ktoso
reviewed
Aug 29, 2025
Move constraint checks into MetricFamily and adopt an approach that favors immutability of MetricFamily members. Co-authored-by: Konrad `ktoso` Malawski <[email protected]> Signed-off-by: Melissa Kilby <[email protected]>
ktoso
reviewed
Aug 29, 2025
ktoso
reviewed
Aug 29, 2025
ktoso
reviewed
Aug 29, 2025
| } | ||
| } | ||
|
|
||
| func add(metric: Metric, for labels: [(String, String)]) -> MetricFamily<Metric> { |
There was a problem hiding this comment.
Minor and doesn’t have to be done, but fyi. In swift often the “add” would be mutating and the not mutating one would be “adding”. But this is fine, just internal api so no need to bikeshed too much
ktoso
approved these changes
Aug 29, 2025
Reduce code duplication further by adding `removing`, `getMetric` and `forEachMetric` to `MetricFamily`. Rename `add` -> `adding` to indicate non mutating nature (Swift convention). Co-authored-by: Konrad `ktoso` Malawski <[email protected]> Signed-off-by: Melissa Kilby <[email protected]>
ktoso
added
🆕 semver/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add {emitToString, emitToBuffer} thread-safe internal buffer management variants to emit metrics.
Deduplicate TYPE and HELP lines per metric name by default on emit.
Fixes #118 @ptoffy
CC @ktoso and @FranzBusch