Don't require to pass a registry on MetricsFactory initialization #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Sep 18, 2023
Comment on lines
+27
to
+28
| /// The underlying ``PrometheusCollectorRegistry`` that is used to generate the swift-metrics handlers | ||
| public var registry: PrometheusCollectorRegistry |
There was a problem hiding this comment.
Do we want this to be public?
There was a problem hiding this comment.
Yes. It should! So that users can access what they got by default.
ktoso
approved these changes
Sep 19, 2023
|
conflict but LGTM |
# Conflicts: # Tests/PrometheusTests/PrometheusMetricsFactoryTests.swift
fabianfett
force-pushed
the
ff-use-factory-singleton
branch
from
3577f9f to
f36234d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require users to explicitly pass a
PrometheusCollectorRegistryonPrometheusMetricsFactorycreation.