Skip to content

Conversation

@lardieri
Copy link
Contributor

@lardieri lardieri commented Aug 2, 2022

CSV files saved by Excel and Airtable include the BOM when encoding to UTF-8.

CSV files saved by Excel and Airtable include the BOM when encoding to UTF-8.
Copy link
Contributor

@DivineDominion DivineDominion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I personally would prefer a change to the "bom" constant to make its meaning more obvious. What do you think?

Unrelated to that, would you want to merge your 0.6.2 fixes with this repo, too, so we can release that to CocoaPods proper?

@lardieri
Copy link
Contributor Author

lardieri commented Aug 3, 2022

I've added additional documentation around the BOM.

I'm happy to submit 0.6.2 for release, but you will need to create a branch in your repo for me to open PR against, since it forks from a previous point (039cc27).

@lardieri lardieri requested a review from DivineDominion August 4, 2022 05:39
Copy link
Contributor

@DivineDominion DivineDominion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the doc comment!

@DivineDominion
Copy link
Contributor

DivineDominion commented Aug 4, 2022

I've opened the branch v0.7. On top of the v0.6.1 release, it includes delimiter guessing, which was compatible with the v0.6 code. Will that be causing any trouble? Happy to discuss in another PR! :)

@DivineDominion DivineDominion merged commit 591d3e7 into swiftcsv:master Aug 4, 2022
@DivineDominion
Copy link
Contributor

Also, thanks a lot for contributing to SwiftCSV! We've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants