[lldb][swift][nfc] Add new overload for AreFuncletsOfSameAsyncFunction #10246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes demangling Nodes instead of strings, to allow libraries to more efficiently re-use demangling nodes.
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 13, 2025
| static FuncletComparisonResult | ||
| AreFuncletsOfSameAsyncFunction(swift::Demangle::NodePointer node1, | ||
| swift::Demangle::NodePointer node2); | ||
|
|
There was a problem hiding this comment.
This may also fit in TypeSystem/Swift/SwiftDemangle.h
There was a problem hiding this comment.
I'll need to look at all of these Are<something>Async<something> functions and figure out where they should go
|
Windows failures are swiftlang/swift-build#300 |
felipepiovezan
merged commit 638f45c
into
swiftlang:stable/20240723
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes demangling Nodes instead of strings, to allow libraries to more efficiently re-use demangling nodes.