[lldb][swift] Only run Swift API tests when Swift support is enabled #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
approved these changes
Oct 1, 2020
JDevlieghere
reviewed
Oct 1, 2020
JDevlieghere
reviewed
Oct 1, 2020
Teemperor
changed the title
Teemperor
force-pushed
the
RunSwiftTestsOnlyWithEnabledSwift
branch
from
7218816 to
03232f1
Compare
|
@swift-ci test |
Teemperor
changed the title
|
swift-ci test platform macos |
|
@swift-ci test platform macos |
Disabling Swift support in LLDB doesn't prevent the test suite from running the Swift tests (which then end up failing instead of being marked as unsupported). This adds swift to the SBDebugger configuration and then checks that Swift is enabled when running Swift API tests.
Teemperor
force-pushed
the
RunSwiftTestsOnlyWithEnabledSwift
branch
from
03232f1 to
2c911bc
Compare
|
@swift-ci test platform macos |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling Swift support in LLDB doesn't prevent the test suite from running
the Swift tests (which then end up failing instead of being marked as
unsupported). This adds swift to the SBDebugger configuration and then checks
that Swift is enabled when running Swift API tests.