Skip to content

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Sep 1, 2023

This is needed to support Swift macros on Windows.

@compnerd compnerd force-pushed the build-part-2 branch 2 times, most recently from a8b0c8f to dfa0b86 Compare September 6, 2023 16:48
@compnerd
Copy link
Member Author

compnerd commented Sep 6, 2023

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 6, 2023

@swift-ci please test

This is needed to support Swift macros on Windows.
@compnerd
Copy link
Member Author

compnerd commented Sep 6, 2023

@swift-ci please test

Copy link

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the hardcoded arch. Can we do the same as Linux there? Could just move the regex match up to the top of the if.

@compnerd
Copy link
Member Author

compnerd commented Sep 7, 2023

I'll unhardcode the arch in a follow up.

@compnerd compnerd merged commit 14cf0de into swiftlang:stable/20221013 Sep 7, 2023
@compnerd compnerd deleted the build-part-2 branch September 7, 2023 15:14
@bulbazord
Copy link

@compnerd Can you also cherry-pick this to stable/20230725 and next so we don't lose track of this change?

@compnerd
Copy link
Member Author

#7470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants