Fix crash in clang/test/CAS/cas-backend.c #7686
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test llvm |
benlangmuir
approved these changes
Oct 25, 2023
felipepiovezan
approved these changes
Oct 25, 2023
|
@swift-ci please test |
PR llvm#68242 changed DWARFUnitHeader::extract to return an Error, which had to be correctly handled in MCCAS. This change fixes that issue. (cherry picked from commit 7773cc5)
rastogishubham
force-pushed
the
FixMCCASStable
branch
from
bf555a7 to
7ec1a4c
Compare
|
@swift-ci please test llvm |
|
@swift-ci please test |
|
@swift-ci please test windows |
|
Oh it seems like llvm#68242 has not been cherry-picked to stable/20230725, so I don't need to cherry-pick this change either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR llvm#68242 changed DWARFUnitHeader::extract to return an Error, which had to be correctly handled in MCCAS. This change fixes that issue.
(cherry picked from commit 7773cc5)