[lldb] Reinstate default constructor for SBCommandInterpreter #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default constructor for SBCommandInterpreter was (unintentionally) made protected in 27b6a4e. The goal of the patch was to make the constructor taking an lldb_private type protected, but due to the presence of a default argument, this ctor also served as the default constructor. The latter should remain public. This commit reinstates the original behavior by removing the default argument and having an explicit, public default constructor. (cherry picked from commit 86f21e9)
Author
|
@swift-ci test |
JDevlieghere
deleted the
jdevlieghere/86f21e92ab6e422edda2c7a1da11670433ad26cb
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default constructor for SBCommandInterpreter was (unintentionally) made protected in 27b6a4e. The goal of the patch was to make the constructor taking an lldb_private type protected, but due to the presence of a default argument, this ctor also served as the default constructor. The latter should remain public.
This commit reinstates the original behavior by removing the default argument and having an explicit, public default constructor.
(cherry picked from commit 86f21e9)