Fix an assert failure with a funclet in a swifttailcc function. #8219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failure happens in the livedebugvalues pass. swiftcc is already covered by isCallingConvWin64. I believe that the assert is checking that the particular calling convention uses a frame pointer, which swifttailcc does, and being relatively a recent addition, it wasn't covered by this code. This cherrypicks the main PR swiftlang#8211
Author
compnerd
approved these changes
Feb 16, 2024
Member
|
@swift-ci please test |
airspeedswift
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure happens in the livedebugvalues pass.
swiftcc is already covered by isCallingConvWin64. I believe that the assert is checking that the particular calling convention uses a frame pointer, which swifttailcc does, and being relatively a recent addition, it wasn't covered by this code.
This cherrypicks the main PR #8211