Don’t crash SourceKit-LSP if swift-format crashes while we write the source file to stdin #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
|
@swift-ci Please test |
ahoppen
force-pushed
the
swift-format-crashing
branch
from
15304f3 to
223e3ca
Compare
…source file to stdin When swift-format crashes before we send all data to its stdin, we get a SIGPIPE when trying to write more data to its studio on Linux. This, in turn, takes SourceKit-LSP down. Do the same trick that we do when launching `JSONRPCConnection` of disabling SIGPIPE globally if we can’t disable it for individual pipes. rdar://147665695
ahoppen
force-pushed
the
swift-format-crashing
branch
from
223e3ca to
f3daf21
Compare
|
swiftlang/swift-tools-support-core#502 @swift-ci Please test |
|
swiftlang/swift-tools-support-core#502 @swift-ci Please test Windows |
hamishknight
approved these changes
Mar 28, 2025
|
swiftlang/swift-tools-support-core#502 @swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When swift-format crashes before we send all data to its stdin, we get a SIGPIPE when trying to write more data to its studio on Linux. This, in turn, takes SourceKit-LSP down.
Do the same trick that we do when launching
JSONRPCConnectionof disabling SIGPIPE globally if we can’t disable it for individual pipes.rdar://147665695