Skip to content

[5.9] Update tests to allow multiple -F options #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[5.9] Update tests to allow multiple -F options #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ final class SwiftPMWorkspaceTests: XCTestCase {
let versionString = PackageModel.Platform.macOS.oldestSupportedVersion.versionString
check("-target", hostTriple.tripleString(forPlatformVersion: versionString), arguments: arguments)
check("-sdk", arguments: arguments)
check("-F", arguments: arguments)
check("-F", arguments: arguments, allowMultiple: true)
#else
check("-target", hostTriple.tripleString, arguments: arguments)
#endif
Expand Down Expand Up @@ -365,7 +365,7 @@ final class SwiftPMWorkspaceTests: XCTestCase {
check("-target",
hostTriple.tripleString(forPlatformVersion: versionString), arguments: arguments)
check("-isysroot", arguments: arguments)
check("-F", arguments: arguments)
check("-F", arguments: arguments, allowMultiple: true)
#else
check("-target", hostTriple.tripleString, arguments: arguments)
#endif
Expand Down Expand Up @@ -609,6 +609,7 @@ private func checkNot(
private func check(
_ pattern: String...,
arguments: [String],
allowMultiple: Bool = false,
file: StaticString = #filePath,
line: UInt = #line)
{
Expand All @@ -617,7 +618,7 @@ private func check(
return
}

if let index2 = arguments[(index+1)...].firstIndex(of: pattern) {
if !allowMultiple, let index2 = arguments[(index+1)...].firstIndex(of: pattern) {
XCTFail(
"pattern \(pattern) found twice (\(index), \(index2)) in \(arguments)",
file: file, line: line)
Expand Down