Add support for looking up spec resources in a toolchain install #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
jakepetroules,
mhrawdon,
mirza-garibovic and
neonichu
as code owners
Collaborator
Author
|
@swift-ci test |
neonichu
approved these changes
Mar 7, 2025
owenv
force-pushed
the
owenv/installed-spec-lookup
branch
from
1219096 to
de18528
Compare
Collaborator
Author
|
@swift-ci test |
jakepetroules
requested changes
Mar 7, 2025
owenv
force-pushed
the
owenv/installed-spec-lookup
branch
from
de18528 to
9da332c
Compare
Collaborator
Author
|
@swift-ci test |
owenv
force-pushed
the
owenv/installed-spec-lookup
branch
from
9da332c to
0f6a64b
Compare
Collaborator
Author
|
@swift-ci test |
jakepetroules
approved these changes
Mar 8, 2025
Collaborator
jakepetroules
left a comment
jakepetroules
left a comment
There was a problem hiding this comment.
Thanks, this looks good!
owenv
force-pushed
the
owenv/installed-spec-lookup
branch
from
e73aefb to
0f6a64b
Compare
Collaborator
Author
|
@swift-ci test |
owenv
force-pushed
the
owenv/installed-spec-lookup
branch
from
0f6a64b to
dedda2e
Compare
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
|
@swift-ci test Windows |
plemarquand
added a commit
to plemarquand/swift-package-manager
that referenced
this pull request
Mar 11, 2025
swiftlang/swift-build#266 changed the API of SwiftBuildService.createSession.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to load resource bundles when installed as part of SwiftPM in a Swift toolchain