Add Sendable to Date, DateComponents and Data #4777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
reviewed
Jun 22, 2023
| A `Date` is independent of a particular calendar or time zone. To represent a `Date` to a user, you must interpret it in the context of a `Calendar`. | ||
| */ | ||
| public struct Date : ReferenceConvertible, Comparable, Equatable { | ||
| public struct Date : ReferenceConvertible, Comparable, Equatable, @unchecked Sendable { |
There was a problem hiding this comment.
Does this need to be @unchecked? I think this can just be Sendable since the type is fairly trivial, and that way we can have some compiler validation on the conformance
|
@swift-ci please test |
|
@swift-ci please test |
jmschonfeld
approved these changes
Jun 27, 2023
|
@swift-ci please test Windows |
FranzBusch
added a commit
to FranzBusch/swift-corelibs-foundation
that referenced
this pull request
Sep 25, 2023
# Motivation In swiftlang#4777, I made them `Sendable` in the overlay instead of the real `Foundation` module. This PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.