Fix the way known locations are generated on windows #4805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GetAllUsersProfileDirectoryW and GetProfilesDirectoryW instead of hardcoding paths. Previously, the known locations were treated as UNC paths, which would typically fail to be read after ~5 second timeout.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
@swift-ci please clean test macOS platform |
|
@swift-ci please test macOS platform |
|
This is a windows only path change, and the failure is an infrastructure failure on the macOS side. |
compnerd
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
GetAllUsersProfileDirectoryWandGetProfilesDirectoryWinstead of hardcoding paths.Previously, the known locations were treated as UNC paths, which would typically fail to be read after ~5 second timeout.
Also fixes memory leak of
usernamestring.