[Windows] FileManager.enumerator(at:) default error handler should continue rather than exiting #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntinue rather than exiting
jmschonfeld
requested review from
compnerd,
iCharlesHu,
itingliu and
parkera
|
@swift-ci test |
compnerd
approved these changes
Nov 19, 2024
|
@swift-ci please test |
jmschonfeld
added a commit
to jmschonfeld/swift-corelibs-foundation
that referenced
this pull request
Nov 20, 2024
…ntinue rather than exiting (swiftlang#5136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Darwin + Linux, the default error handler for
FileManager.enumerator(at:)continues on error (and this is the documented behavior as well) however on Windows the default error handler stops enumeration at an error. This updates the Windows behavior to match the Darwin + Linux behavior.