Allow light mode in Hero and color updates #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update hero color
Add test and update header
chore: clean up
|
@swift-ci test |
Fix color for Language Switcher
revert `isHeroDark` prop
remove unnecessary theme-dark CSS
marinaaisa
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Hi @hqhhuang , great job! I tested it and it looks good!
I added some questions related to prefers-dark and theme-dark to see if we can simplify and avoid duplication of code.
update background color and icon style
chore: fix headers
…nder into update-hero-style
|
@swift-ci test |
mportiz08
reviewed
Feb 9, 2024
Make badge text darker
Update language switcher style
|
@swift-ci test |
mportiz08
approved these changes
Feb 12, 2024
marinaaisa
approved these changes
Feb 13, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 120847903
Summary
This PR adds the ability to have light mode background in the hero and updates gradient style.
Testing
Steps:
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test, and it succeeded