Skip to content

[6.0] Support thematic breaks #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2024
Merged

[6.0] Support thematic breaks #795

merged 2 commits into from
Apr 2, 2024

Conversation

@mportiz08
Copy link
Contributor

  • Explanation: Adds support for rendering thematic breaks using horizontal rules
  • Scope: Only impacts content with thematic break syntax, compiled with supporting DocC version
  • Issue: rdar://125507297
  • Risk: Low, small additive change that has no impact on content without new syntax
  • Testing: Added unit tests. Verified that new syntax gets rendered as horizontal rule when compiled with supported DocC version. Tested that no rendering changes occur without syntax and/or with unsupported DocC version.
  • Reviewer: @marinaaisa and @emilyychenn
  • Original PR: Support thematic breaks #791

@mportiz08
Support thematic breaks (swiftlang#791)
dcf63ed 
Add support for "thematic breaks" using `<hr>`.

Resolves: rdar://125507297
@mportiz08 mportiz08 requested a review from franklinsch March 27, 2024 20:48
@mportiz08
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit e0302f2 into swiftlang:release/6.0 Apr 2, 2024
@mportiz08 mportiz08 deleted the 6.0/support-thematic-breaks branch April 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mportiz08 @franklinsch