Skip to content

[5.9] Use a custom scheme for local "Declared In" source file URLs (#513) #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

[5.9] Use a custom scheme for local "Declared In" source file URLs (#513) #518

merged 2 commits into from
Mar 27, 2023

Conversation

@d-ronnqvist
Copy link
Contributor

Cherry-pick of #513

  • Explanation: Use a custom scheme for local "Declared In" source files for easier customizability.
  • Scope: Local "Declared In" source file URL
  • Radar: rdar://106667647
  • Risk: Low.
  • Testing: Updated tests verify the new scheme. Existing automated tests pass.
  • Reviewer: @ethan-kusters

@d-ronnqvist d-ronnqvist requested a review from franklinsch March 24, 2023 18:45
@d-ronnqvist d-ronnqvist changed the title Use a custom scheme for local "Declared In" source file URLs (#513) [5.9] Use a custom scheme for local "Declared In" source file URLs (#513) Mar 24, 2023
@d-ronnqvist d-ronnqvist changed the base branch from main to release/5.9 March 24, 2023 18:47
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 8a2419f into swiftlang:release/5.9 Mar 27, 2023
@d-ronnqvist d-ronnqvist deleted the declared-in-source-file-scheme-5.9 branch March 27, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-ronnqvist @franklinsch