Skip to content

Conversation

@d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Jun 24, 2023

Cherry-pick of #642

  • Explanation: This fixes a false-positive link resolution warning by moving the creation of the resolved reference lookup earlier in the content registration so that it's available if curation crawling takes two passes.
  • Scope: Curated symbols with special characters (for example <=(_:_:))
  • Issue: rdar://111227479
  • Risk: Low.
  • Testing: Added new automated test to verify that curating these symbols no longer cause false positive warnings.
  • Reviewer: @QuietMisdreavus

…wiftlang#642)

* Fix false-positive warning for curated symbols with special characters

rdar://111227479

* Remove redundant symbol index modification
@d-ronnqvist d-ronnqvist requested a review from franklinsch June 24, 2023 00:50
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 195c123 into swiftlang:release/5.9 Jun 26, 2023
@d-ronnqvist d-ronnqvist deleted the false-positive-operator-curation-warnings-5.9 branch February 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants