Skip to content

Conversation

@d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Apr 2, 2024

Bug/issue #, if applicable: rdar://125785105

Summary

This follows up on #861 to add back the temporarily reverted commit to use package access level (SE-0386, available from Swift 5.9) instead of SPI for FileManagerProtocol.

Dependencies

None

Testing

Nothing in particular. This isn't a use facing change.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary

@d-ronnqvist d-ronnqvist added the code cleanup Code cleanup *without* user facing changes label Apr 2, 2024
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@patshaughnessy patshaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit a1335c3 into swiftlang:main Apr 4, 2024
@d-ronnqvist d-ronnqvist deleted the package-access-file-manager-protocol branch April 4, 2024 08:18
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Apr 4, 2024
d-ronnqvist added a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code cleanup Code cleanup *without* user facing changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants