Skip to content

Conversation

MaxDesiatov
Copy link
Contributor

This was also an opportunity to convert some of Result-returning properties to get throws effectful properties, which simplified some code.

cc @neonichu

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MaxDesiatov

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test macOS

@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test Linux

1 similar comment
@MaxDesiatov
Copy link
Contributor Author

@swift-ci please test Linux

@MaxDesiatov
Copy link
Contributor Author

closing as superseded by #1231

@MaxDesiatov MaxDesiatov deleted the maxd/fix-deprecated-absolutepath branch November 30, 2022 17:40
@artemcm
Copy link
Contributor

artemcm commented Nov 30, 2022

Sorry @MaxDesiatov, completely forgot about this.

@MaxDesiatov
Copy link
Contributor Author

No worries, I couldn't merge it at that time, had no commit access for this repository. Looks like that has been resolved since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants