Skip to content

Conversation

MaxDesiatov
Copy link
Contributor

This error diagnostic doesn't make sense when linking on Linux with Musl, which allows fully statically linked executables.

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Jun 20, 2023
@MaxDesiatov MaxDesiatov requested a review from artemcm June 20, 2023 09:23
@MaxDesiatov MaxDesiatov self-assigned this Jun 20, 2023
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov requested review from al45tair and etcwilde June 21, 2023 08:29
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me; I wonder whether Triple should grow a supportsStaticExecutables property though, rather than explicitly testing for .musl in here?

@MaxDesiatov MaxDesiatov requested a review from al45tair June 21, 2023 09:30
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test windows

@rauhul
Copy link
Member

rauhul commented Jun 21, 2023

Seems reasonable to me; I wonder whether Triple should grow a supportsStaticExecutables property though, rather than explicitly testing for .musl in here?

+100, I was planning on adding a supportsDynamicExecutables to handle os(none)

@MaxDesiatov
Copy link
Contributor Author

Not merging this yet as I want to add a test or two that cover this.

@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov MaxDesiatov merged commit 256c95c into main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants