[ELF] Don't pass ELF shared objects to autolink-extract #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
approved these changes
Aug 21, 2023
artemcm
approved these changes
Aug 21, 2023
This is a version of swiftlang/swift#30465 for the new driver. Since shared objects are classified as `.object`, they end up getting passed to the autolink-extract job. For ELF platforms, this is unnecessary, since the autolink entries are not in the final shared object, so the autolink-extract process will not find any entries. Additionally, in ELF platforms, `.so` files can actually be linker scripts (text files) with instructions for the actual linker, which the autolink-extract job will not understand and will fail. For those two reasons, modify the autolink-extract inputs to skip over objects in ELF platforms that have the `.so` extension.
drodriguez
force-pushed
the
elf-so-autolink-extract
branch
from
479ff34 to
d134679
Compare
|
@swift-ci please test |
|
I don't have permissions to merge into this repo. Can someone be kindly enough to do it for me? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of swiftlang/swift#30465 for the new driver.
Since shared objects are classified as
.object, they end up getting passed to the autolink-extract job.For ELF platforms, this is unnecessary, since the autolink entries are not in the final shared object, so the autolink-extract process will not find any entries.
Additionally, in ELF platforms,
.sofiles can actually be linker scripts (text files) with instructions for the actual linker, which the autolink-extract job will not understand and will fail.For those two reasons, modify the autolink-extract inputs to skip over objects in ELF platforms that have the
.soextension.