Skip to content

Conversation

cachemeifyoucan
Copy link
Contributor

Generate correct Options.swift from new option tablegen output format after https://reviews.llvm.org/D157029.

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link

@jansvoboda11 jansvoboda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Generate correct `Options.swift` from new option tablegen output format
after https://reviews.llvm.org/D157029.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-makeOptions-D157029-fix branch from 11fa0e5 to 752f526 Compare August 28, 2023 20:30
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan
Copy link
Contributor Author

Windows test actually passed here: https://ci-external.swift.org/job/swift-driver-PR-windows/563/
But it is not reported, now all the nodes are offline.

@cachemeifyoucan cachemeifyoucan merged commit b202171 into swiftlang:main Aug 29, 2023
@cachemeifyoucan cachemeifyoucan deleted the eng/PR-makeOptions-D157029-fix branch August 29, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants