Skip to content

Adjust 'makeOptions' to new TableGen format of Swift's 'Options.inc' #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2023
Merged

Adjust 'makeOptions' to new TableGen format of Swift's 'Options.inc' #1474

merged 1 commit into from
Nov 1, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Oct 26, 2023

No description provided.

@artemcm
Copy link
Contributor Author

artemcm commented Oct 26, 2023

@swift-ci test

cachemeifyoucan
cachemeifyoucan reviewed Oct 26, 2023
View reviewed changes
@artemcm artemcm force-pushed the RebranchTableGenMakeOptions branch from 9fb0419 to 432ff74 Compare October 26, 2023 19:12
@artemcm
Copy link
Contributor Author

artemcm commented Oct 26, 2023

@swift-ci test

@artemcm artemcm force-pushed the RebranchTableGenMakeOptions branch from 432ff74 to 2b48887 Compare October 26, 2023 19:20
@artemcm
Copy link
Contributor Author

artemcm commented Oct 26, 2023

@swift-ci test

@artemcm artemcm force-pushed the RebranchTableGenMakeOptions branch from 2b48887 to aaa7270 Compare October 26, 2023 19:23
@artemcm
Copy link
Contributor Author

artemcm commented Oct 26, 2023

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Oct 26, 2023

CI is busted for an unrelated reason:

/Users/ec2-user/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/.build/checkouts/swift-llbuild/lib/Basic/include/llbuild/Basic/Tracing.h:179:84: error: format specifies type 'int' but the argument has type 'EngineQueueItemKind' [-Werror,-Wformat]

@artemcm
Copy link
Contributor Author

artemcm commented Oct 31, 2023

@swift-ci test

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Nov 1, 2023

@swift-ci test

@artemcm artemcm merged commit 376a516 into swiftlang:main Nov 1, 2023
@artemcm artemcm deleted the RebranchTableGenMakeOptions branch November 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@artemcm @cachemeifyoucan