[6.0 🍒][Explicit Module Builds][Incremental Builds] Re-compile module dependencies whose dependencies are up-to-date themselves but are newer #1629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necies whose dependencies are up-to-date themselves but are themselves newer
For example consider the following module graph:
test
\
J
\
G
Where on an incremental build we detect that although G binary module product is *newer* than its textual source, said binary module product is also *newer* than a prior binary module product of J. Which means that although each of the modules is up-to-date with respect to its own textual source inputs, J's binary dependnecy input has been updated elsewhere and J needs to be re-built.
Resolves rdar://129225956
…extension on the graph itself
…k if a prior inter-module dep graph is up-to-date with a check to decide which modules to re-build Using the same 'computeInvalidatedModuleDependencies' routine, which is more thorough and checks module inputs to each dependency as well.
|
@swift-ci test |
|
@swift-ci test macOS platform |
nkcsgexi
approved these changes
Jun 12, 2024
…licitly-built module tests to avoid conflicts on parallel test runs
|
@swift-ci test |
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1628
Explanation: For example consider the following module graph:
graph LR; test-->J; J-->G;Where on an incremental build we detect that although
Gbinary module product is newer than its textual source, said binary module product is also newer than a prior binary module product ofJ. Which means that although each of the modules is up-to-date with respect to its own textual source inputs,J's module dependency's binary input has been updated elsewhere andJneeds to be re-built.Risk: Low. This change adds to incremental explicitly-built module re-build filtering logic to also check timestamps of module dependency outputs of a given module dependency. This was not handled before and could lead to unsound incremental builds. The risk is relatively low because this is still off on the default code-path.
Testing: Automated tests added to the compiler and driver suite.
Reviewed By: @owenv
Resolves rdar://129225956