[6.0 🍒][Explicit Module Builds] Remove dead/incorrect code for handling header inputs of binary module dependencies #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er inputs of binary module dependencies As of swiftlang/swift#72067, we instead serialize `.h` inputs directly into binary `.swiftmodule` files, because their clients may not be able to use the dependnecies' corresponding `.pch` files due to a compilation context mismatch. The clients of such binary modules then consume the serialized `.h` files directly, and compile them, implicitly, using explicit module dependencies collected during scan of such header files. Resolves rdar://131261765
|
@swift-ci test |
DougGregor
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.hinputs directly into binary.swiftmodulefiles, because their clients may not be able to use the binary module's corresponding.pchfiles due to a compilation context mismatch. The clients of such binary modules then consume the serialized.hfiles directly, and compile them, implicitly, using explicit module dependencies collected during scan of such header files. This change removes leftover code that relied on a prior, incorrect, assumption that we pass on binary dependencies' PCH inputs to their clients..swiftmoduledependency which was built with a bridging header.