[6.0] Import new Android overlay or Bionic module #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix build error because `strsignal()` always returns `_Nonnull` in the latest Android NDK 26.
compnerd
approved these changes
Jul 16, 2024
|
@swift-ci please test |
|
Passed CI, ready for merge. |
|
Any further sign-off needed or this can be merged? |
|
Ping @artemcm, anybody else need to sign off on this being merged? |
|
@bnbarham, can you go ahead and merge? |
nkcsgexi
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Now that this new overlay was merged into the 6.0 compiler too in swiftlang/swift#74758, this adds the overlay to the six files that currently
import Glibcin this repo and fixes a build error becausestrsignal()always returns_Nonnullin the latest Android NDK 26.Scope: Add imports and a build fix on Android only
Issue: None
Original PR: #1647
Risk: None
Testing: Passed all CI on trunk, plus now builds with the new Android overlay on my daily Android CI, finagolfin/swift-android-sdk#156
Reviewer: @compnerd
@artemcm, easy review.