[5.7] Fix Repeat off-by-one error #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the upper bound of the Range down when forming the quantification, as it expects an inclusive upper bound.
Seems like we ought to crash in a release build instead of potentially crashing during byte code emission or silently failing to match.
|
@swift-ci please test |
milseman
approved these changes
Jul 1, 2022
stephentyrone
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.7 cherry-pick of #535
Adjust the upper bound of the Range down when forming the quantification, as it expects an inclusive upper bound. Additionally, upgrade a couple of assertions to preconditions to ensure we don't silently fail byte code emission.
Resolves #478