Skip to content

Conversation

a7medev
Copy link
Member

@a7medev a7medev commented Oct 8, 2025

Keep empty trailing closure parentheses in a curried call to avoid the compiler associating the trailing closure with the called expression (which is itself a call) breaking the code.

Fixes #1070

@a7medev
Copy link
Member Author

a7medev commented Oct 8, 2025

@swift-ci please test

@a7medev a7medev force-pushed the fix/empty-trailing-closure-parens-curried branch from 34e77db to cb9c1d3 Compare October 8, 2025 21:45
@a7medev
Copy link
Member Author

a7medev commented Oct 8, 2025

@swift-ci please test

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@bnbarham I saw your PR #1072 trying to deal with the older Windows toolchain issues; do you want to wait for that to resolve before we merge changes like this? (It seems fine, given that it passes everywhere else.)

@bnbarham
Copy link
Contributor

bnbarham commented Oct 9, 2025

I'm fine with merging, they're currently required but if you give me a ping I'll force merge it. I know what it is now, just need to find a way to workaround it.

@bnbarham bnbarham merged commit 096a20a into swiftlang:main Oct 9, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrectly removing empty trailing closure parentheses in a curried call

3 participants